Page MenuHomeWildfire Games

Removes team bonus when the source player is defeated.
ClosedPublic

Authored by fatherbushido on Dec 26 2016, 7:13 PM.

Details

Summary

Team bonus can be done with a player entity aura. Currently team bonus are not removed when its source player is defeated. Bug noticed by mimo (refs #4082)

Test Plan

You can check that your ally iberian team bonus is indeed removed when he's defeated.
Take care to test resign and defeat.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

fatherbushido updated this revision to Diff 38.Dec 26 2016, 7:13 PM
fatherbushido retitled this revision from to Removes team bonus when the source player is defeated..
fatherbushido updated this object.
fatherbushido edited the test plan for this revision. (Show Details)

A regression test for this would be nice.

fatherbushido edited the test plan for this revision. (Show Details)
fatherbushido set the repository for this revision to rP 0 A.D. Public Repository.

Add a regression test.

Vulcan added a subscriber: Vulcan.Dec 27 2016, 10:54 AM

Build is green

Build (release)...
../../../source/gui/CChart.cpp:38:41: warning: unused parameter ‘Message’ [-Wunused-parameter]
 void CChart::HandleMessage(SGUIMessage& Message)
                                         ^
../../../source/lib/tex/tex_png.cpp: In member function ‘virtual Status TexCodecPng::encode(Tex*, DynArray*) const’:
../../../source/lib/tex/tex_png.cpp:309:9: warning: variable ‘ret’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Wclobbered]
  Status ret = ERR::FAIL;
         ^
Build (debug)...
../../../source/gui/CChart.cpp:38:41: warning: unused parameter ‘Message’ [-Wunused-parameter]
 void CChart::HandleMessage(SGUIMessage& Message)
                                         ^
Running debug tests...

http://jw:8080/job/phabricator/20/ for more details.

wraitii accepted this revision.Dec 29 2016, 3:37 PM
wraitii added a reviewer: wraitii.
wraitii added a subscriber: wraitii.

Works for the Iberian case at least, tests are OK. Ought to be good.

This revision is now accepted and ready to land.Dec 29 2016, 3:37 PM
This revision was automatically updated to reflect the committed changes.
elexis changed the visibility from "All Users" to "Public (No Login Required)".Mar 25 2017, 6:02 PM