Atlas should ignore JSON files that aren't maps
ClosedPublic
Actions

Authored by elexis on Feb 15 2018, 7:12 PM.

Details

Reviewers: None
Commits: rP21223: Atlas should only list map JSON files as maps.

Summary

It should be possible that random map scripts can provide custom JSON files without atlas advertizing them as maps without title.
rP20157 is one example, another is a new map that has all template and texture names moved to a JSON file.

Test Plan

Notice that we have to read the JSON file anyhow to determine if it's a map, at least with the current directory structure.
http://docs.wxwidgets.org/3.1/classwx_string.html#ace32756bab999f8aae9be0cf981fc449
http://docs.wxwidgets.org/3.0/classwx_string.html
http://docs.wxwidgets.org/2.9/classwx_string.html

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Feb 15 2018, 7:12 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/18/display/redirect

Harbormaster completed remote builds in B4972: Diff 5785.Feb 15 2018, 7:16 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2018, 5:43 PM

Closed by commit rP21223: Atlas should only list map JSON files as maps. (authored by elexis). · Explain Why

This revision was automatically updated to reflect the committed changes.

Owners added a subscriber: Restricted Owners Package.Feb 16 2018, 5:43 PM

Revision Contents
Changeset List

Path

Size

ps/

trunk/

source/

tools/

atlas/

AtlasUI/

ScenarioEditor/

Sections/

Map/

Map.cpp

5 lines

Diff 5797

View Options

ps/trunk/source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Map/Map.cpp

Atlas should ignore JSON files that aren't mapsClosedPublicActions