Split from D1287.
Adapted the template analyzer in source/tools to see if the obstructions of any building was bigger than its footprint, which would cause trouble for spawning. Elephant stables and the Ptolemy civic center needed changes. Made the Carthage elephant stable inherit like the others.
Went through the circular footprints by hand, which are awkward because the obstructions are still rectangular. They were fine except for small ships from the Briton crannog, so I used a slightly larger footprint so they'd have an easier time spawning without hitting the crannog's obstruction.
Details
- Reviewers
bb - Commits
- rP21308: Adjust some footprints and obstructions to better handle spawning
Circular obstructions: (Wonders are awkward but units have space to ungarrison on the sides.)
Crannog before and after the footprint change:
Ships spawning from docks, units ungarrisoning from ships (out the front which extends beyond the square obstruction), siege spawning from forts, units ungarrisoning from siege, and units spawning from heroes all seemed okay (although I didn't test every single combination).
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
They seem fine. (The problem of course is circular footprints and rectangular obstructions.)
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/19/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/27/display/redirect
did not test, judging from screenshots it should be ok
elephant stable move was reviewed in last iteration.