Page MenuHomeWildfire Games

Small StatisticsTracker test
ClosedPublic

Authored by Imarok on Feb 17 2018, 6:16 PM.

Details

Summary

Adds a test for the only difficult(= easy breakable) function in this component.

Test Plan

test the test

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Imarok requested review of this revision.Feb 17 2018, 6:16 PM
Imarok created this revision.
Vulcan added a subscriber: Vulcan.Feb 17 2018, 9:27 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Default...
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (comma-spacing):
|    | A space is required after ','.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/tests/test_StatisticsTracker.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/tests/test_StatisticsTracker.js
|  27|  27| };
|  28|  28| 
|  29|  29| cmpStatisticsTracker.PushValue(obj1, obj2);
|  30|    |-TS_ASSERT_UNEVAL_EQUALS(obj2,{
|    |  30|+TS_ASSERT_UNEVAL_EQUALS(obj2, {
|  31|  31| 	"foo": [11, 13, 17, 3],
|  32|  32| 	"bar": {
|  33|  33| 		"diz": [19, 23, 5],

Link to build: https://jenkins.wildfiregames.com/job/differential/32/display/redirect

Imarok updated this revision to Diff 5822.Feb 18 2018, 12:48 AM

Space and meaningfull names

elexis accepted this revision.Feb 18 2018, 3:01 AM
elexis added a subscriber: elexis.

Good

binaries/data/mods/public/simulation/components/tests/test_StatisticsTracker.js
3 ↗(On Diff #5822)

group interfaces

This revision is now accepted and ready to land.Feb 18 2018, 3:01 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/38/display/redirect

This revision was automatically updated to reflect the committed changes.