Page MenuHomeWildfire Games

Fix debug mode after rP21239
ClosedPublic

Authored by Imarok on Feb 21 2018, 11:36 PM.

Details

Summary

Fix debug mode after rP21239

Test Plan

start a game in debug mode. You may not get a MOZ_JS error

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Imarok created this revision.Feb 21 2018, 11:36 PM
elexis added inline comments.
source/ps/SavedGame.cpp
85 ↗(On Diff #5870)

group with initAttributes?

Imarok edited the summary of this revision. (Show Details)Feb 21 2018, 11:46 PM
temple accepted this revision.Feb 22 2018, 1:09 AM
temple added a subscriber: temple.

Had this error starting a debug game without the patch, no error with the patch:

Assertion failure: mStatementDone, at ../../../libraries/source/spidermonkey/include-unix-debug/mozilla/GuardObjects.h:100
This revision is now accepted and ready to land.Feb 22 2018, 1:09 AM
Vulcan added a subscriber: Vulcan.Feb 22 2018, 8:22 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/64/display/redirect

This revision was automatically updated to reflect the committed changes.