Page MenuHomeWildfire Games

Don't use "all" in ranged aura strings

Authored by temple on Feb 22 2018, 6:46 PM.



I went through grep "all " -i in the aura directory by hand, most were global but two were range. These should say "nearby" or similar instead.

Test Plan


Diff Detail

rP 0 A.D. Public Repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis accepted this revision.Feb 22 2018, 6:54 PM
elexis added a subscriber: elexis.

Apparently we only show if it's a ranged aura if it's a ranged aura, (i.e. the player is left clueless if it's a global aura). Otherwise we could make the strings agnostic of "all" and "nearby" and just speak of the effect.

Patch correct. Don't know if it's complete, assuming your completeness test is correct. If it isn't not the end of the world.

This revision is now accepted and ready to land.Feb 22 2018, 6:54 PM
This revision was automatically updated to reflect the committed changes.
Vulcan added a subscriber: Vulcan.Feb 22 2018, 8:29 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: