Paths

Table of Contentst

Differential D1321

Don't use "all" in ranged aura strings
ClosedPublic
Actions

Authored by temple on Feb 22 2018, 6:46 PM.

Details

Reviewers

elexis

Commits

rP21320: Don't use "all" in ranged aura strings

Summary

I went through grep "all " -i in the aura directory by hand, most were global but two were range. These should say "nearby" or similar instead.

Test Plan

Agree.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Ref rP21269.

Apparently we only show if it's a ranged aura if it's a ranged aura, (i.e. the player is left clueless if it's a global aura). Otherwise we could make the strings agnostic of "all" and "nearby" and just speak of the effect.

Patch correct. Don't know if it's complete, assuming your completeness test is correct. If it isn't not the end of the world.

This revision is now accepted and ready to land.Feb 22 2018, 6:54 PM

asterix added a subscriber: asterix.Feb 22 2018, 6:55 PM

Closed by commit rP21320: Don't use "all" in ranged aura strings (authored by temple). · Explain WhyFeb 22 2018, 6:58 PM

This revision was automatically updated to reflect the committed changes.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/72/display/redirect

Harbormaster completed remote builds in B5128: Diff 5881.Feb 22 2018, 8:29 PM

temple mentioned this in rP21714: Adjust some hero auras.Apr 14 2018, 2:11 AM

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

simulation/

data/

auras/

units/

heroes/

cart_hero_hamilcar_1.json

2 lines

cart_hero_hannibal.json

2 lines

Diff 5882

View Options

ps/trunk/binaries/data/mods/public/simulation/data/auras/units/heroes/cart_hero_hamilcar_1.json