I think nobody would expect its ship to be blocked by a small floating barrel.
And the current pathfinder is quite bad and sometime ships are blocked in-between two nearby such debris.
Details
Details
- Reviewers
elexis - Commits
- rP21349: Small floating debris should not block ship movement.
agree or not with the change
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Those are only 3 barrels, very small, so overlapping of the models isn't really noticeable.
If you rename that file to not have shipwreck in the name, i.e. to barrels_floating or the like I wouldn't disagree.
It's the same model as food_barrels_buried.
The other shipwrecks should probably keep it, though woulnd't raise a concern if collision is removed there.
(also please have a look at D1326 in case it's not already on your table)
Comment Actions
yes, it looks fine
If you rename that file to not have shipwreck in the name, i.e. to barrels_floating or the like I wouldn't disagree.
It's the same model as food_barrels_buried.
We'd have to also change all maps which have it. I'd rather not do that now.
The other shipwrecks should probably keep it, though woulnd't raise a concern if collision is removed there.
agree that the other ones should keep it.
(also please have a look at D1326 in case it's not already on your table)
ok
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/86/display/redirect