Page MenuHomeWildfire Games

African Plains
ClosedPublic

Authored by Hannibal_Barca on Feb 7 2017, 6:12 PM.

Details

Summary

A new random set-biome map.

Test Plan

Test map for bugs and other deficiencies.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Hannibal_Barca created this revision.Feb 7 2017, 6:12 PM
Imarok added a subscriber: Imarok.Feb 7 2017, 6:41 PM

Map preview image is missing

fatherbushido resigned from this revision.Feb 7 2017, 6:42 PM
Hannibal_Barca edited the summary of this revision. (Show Details)Feb 7 2017, 6:57 PM
elexis edited edge metadata.

Thanks for the preview image! I'd disable fog for the preview image though, so that the colors come out better

Can copy & paste the JS file to www.jshint.com and check whether there are unused variables?

Also fed the screenshot to arcadius who cried about the forest and metal amount being biased towards some players, but that's kind of expected as it's a random map. (Doing a more equal balance can be done in a big overhaul, adding a new option in the gamesetup)

binaries/data/mods/public/maps/random/african_plains.js
2 ↗(On Diff #476)

Do we actually use anything from rmlib2 in this file? Can't find anything, so the reference can be nuked

5 ↗(On Diff #476)

In case you're interested, there are some more functions about water, sun and skybot settings in environment.js

52 ↗(On Diff #476)

This odd looking variable is used only once, better nuke it and replace the reference to it with it's value

123 ↗(On Diff #476)

Same, the comment can go too then

binaries/data/mods/public/maps/random/african_plains.json
5 ↗(On Diff #476)

wild game? not wildlife?

elexis edited the summary of this revision. (Show Details)Feb 7 2017, 7:13 PM
elexis edited the test plan for this revision. (Show Details)
Vulcan added a subscriber: Vulcan.Feb 7 2017, 7:33 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running debug tests...
Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/329/ for more details.

elexis added inline comments.Feb 7 2017, 7:56 PM
binaries/data/mods/public/maps/random/african_plains.js
90 ↗(On Diff #476)

Oh, also we use ++i instead of i++ where possible

Hannibal_Barca marked 3 inline comments as done.Feb 8 2017, 9:36 PM
Hannibal_Barca marked an inline comment as not done.Feb 8 2017, 9:43 PM
Hannibal_Barca marked an inline comment as not done.

Changes suggested by elexis applied.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/352/ for more details.

elexis accepted this revision.EditedFeb 13 2017, 3:15 AM
  • Created a new thumbnail as the fog was really ugly
  • Moved the stone mine function that was copied from sahel to rmlib/
  • The JSON file was messed up in the last update somehow by copying the description from arctic summer which entirely does not fit for this map. Used the previous description and applied the wild game -> wild animals correction.
  • Reduced fog factor and thickness, gave fog a slight red tone, as the white fog is more suitable to dense forests
  • Changed ix++ to ++ix
  • Fixed whitespace in programming.json
This revision is now accepted and ready to land.Feb 13 2017, 3:15 AM
This revision was automatically updated to reflect the committed changes.

Build has FAILED

Link to build: http://jw:8080/job/phabricator/355/
See console output for more information: http://jw:8080/job/phabricator/355/console