Differential D1364

Linting: allow constant condition in loops
ClosedPublic
Actions

Authored by Imarok on Mar 8 2018, 8:24 PM.

Details

Reviewers

Itms

Commits

rP22101: Linting: allow constant condition in loops

Summary

Allow constant condition in loops

Test Plan

gamesetup_mp.js

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Imarok created this revision.Mar 8 2018, 8:24 PM

Harbormaster completed remote builds in B5403: Diff 6067.Mar 8 2018, 8:24 PM

Owners added a subscriber: Restricted Owners Package.Mar 8 2018, 8:24 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/182/display/redirect

Harbormaster completed remote builds in B5403: Diff 6067.Mar 8 2018, 11:10 PM

@Itms ping

Finally tested it ? It works on the Jenkins slave, you can commit it!

This revision is now accepted and ready to land.Feb 24 2019, 6:18 PM

Closed by commit rP22101: Linting: allow constant condition in loops (authored by Imarok). · Explain WhyMar 3 2019, 11:48 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

ps/

trunk/

build/

jenkins/

lint-config/

eslintrc.json

2 lines

Diff 7509

View Options

ps/trunk/build/jenkins/lint-config/eslintrc.json

Linting: allow constant condition in loopsClosedPublicActions