Page MenuHomeWildfire Games

freehand position tip on loading screen
ClosedPublic

Authored by OptimusShepard on Mar 10 2018, 12:19 AM.

Details

Summary

add loading screen tip for freehand position{F405912}

Test Plan

enjoy loading screen

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Does someone know how to adjust the picture correctly?

elexis edited the summary of this revision. (Show Details)Mar 10 2018, 12:57 AM
elexis added a reviewer: Stan.
Vulcan added a subscriber: Vulcan.Mar 10 2018, 1:44 AM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:

Link to build: https://jenkins.wildfiregames.com/job/differential/203/display/redirect

Stan added a comment.Mar 10 2018, 8:29 AM

Can you upload the picture separately ? Phabricator doesn't like binary files much :/

Imarok added a subscriber: Imarok.Mar 10 2018, 8:55 AM

It's in the top post.

Stan added a comment.Mar 10 2018, 9:59 AM

Ah my bad. I'm not too found of the mouse to be honest.

Do you prefer some other colors, or completely with out?

maybe more 0AD style

take what you prefer

without blue shadows

elexis added a subscriber: elexis.Mar 10 2018, 11:34 AM

About the imge format itself, do what the other files do, i.e. 512*512 with the actual contents 512*384. Not sure if the rest has to be transparent or if black works too.

I like the 0AD unit formation, really shows what it can do. But perhaps it should take place on a more beautiful map than anatolian plateau.

The mouse has an mspaint feeling to it like Stan said, perhaps we can omit it altogether and just describe it in the tooltip.
(Also eventually it should become a hotkey, not hardcoded to the rightclick.)

binaries/data/mods/public/gui/text/tips/freehand_position.txt
2 ↗(On Diff #6099)

That's tactics, not strategy

4 ↗(On Diff #6099)

Therefore

Players won't know what M2 is. (Hardcoded button issue. That hardcoding however might not change soon. Not sure if we can describe how to interact without mentioning the assigned virtual key)

update the text

OptimusShepard marked an inline comment as done.Mar 10 2018, 1:43 PM
In D1368#56469, @elexis wrote:

About the imge format itself, do what the other files do, i.e. 512*512 with the actual contents 512*384. Not sure if the rest has to be transparent or if black works too.

Can someone else please add the transparency, black didn't work?

I like the 0AD unit formation, really shows what it can do. But perhaps it should take place on a more beautiful map than anatolian plateau.

The mouse has an mspaint feeling to it like Stan said, perhaps we can omit it altogether and just describe it in the tooltip.

nearly ^^ I did it with Visio :D

(Also eventually it should become a hotkey, not hardcoded to the rightclick.)

I think right mouse is more intuitiv and practicaly than a hotkey?

OptimusShepard marked an inline comment as done.Mar 10 2018, 1:43 PM
Stan added a comment.Mar 10 2018, 1:54 PM

I guess the idea behind the hotkey would be to allow one to use right click drag for something else if they see fit.

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:

Link to build: https://jenkins.wildfiregames.com/job/differential/212/display/redirect

So we change it if we have a usecase?

add transparency to picture

Imarok added inline comments.Mar 11 2018, 10:59 AM
binaries/data/mods/public/gui/text/tips/freehand_position.txt
4 ↗(On Diff #6111)

than -> then

I think right mouse is more intuitiv and practicaly than a hotkey?

Mouse buttons are virtual keys too, thus can be assigned to hotkeys as well.

OptimusShepard added inline comments.Mar 11 2018, 6:00 PM
binaries/data/mods/public/gui/text/tips/freehand_position.txt
4 ↗(On Diff #6111)

May you please change it when you're commiting, I don't have access to my pc at the moment?

Imarok added inline comments.Mar 11 2018, 6:05 PM
binaries/data/mods/public/gui/text/tips/freehand_position.txt
4 ↗(On Diff #6111)

I was not requesting changes, just adding a note...

Stan added a comment.Mar 11 2018, 7:21 PM

Image looks fine, since the text is okay.

Imarok accepted this revision.Mar 11 2018, 8:11 PM
This revision is now accepted and ready to land.Mar 11 2018, 8:11 PM
This revision was automatically updated to reflect the committed changes.
Owners added subscribers: Restricted Owners Package, Restricted Owners Package.Mar 11 2018, 8:19 PM