Page MenuHomeWildfire Games

Remove ResourceGatherer and trample tooltips for chariots
ClosedPublic

Authored by temple on Mar 10 2018, 2:43 AM.

Details

Summary

Champions can't gather so ResourceGatherer is unnecessary, and the Persian chariot should gather the same as other cavalry for now (even though it doesn't have an animation for it). Also, unfortunately we haven't implemented trample damage yet.

Test Plan

Agree.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

temple created this revision.Mar 10 2018, 2:43 AM
Vulcan added a subscriber: Vulcan.Mar 10 2018, 4:34 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/209/display/redirect

elexis accepted this revision.Mar 10 2018, 11:27 AM
elexis added a subscriber: elexis.
elexis added inline comments.
binaries/data/mods/public/simulation/templates/units/maur_champion_chariot.xml
16 ↗(On Diff #6107)

Ok to remove, but why weren't they able to gather when they had this component?

binaries/data/mods/public/simulation/templates/units/pers_cavalry_archer_b.xml
14 ↗(On Diff #6107)

Might want to check other tooltips having the same.
There's a fatherbushido ticket around for cleaning old tooltips, I'd be ok with a great purge, just noone cared.

23 ↗(On Diff #6107)

That was fun, ok to nuke

This revision is now accepted and ready to land.Mar 10 2018, 11:27 AM
temple added inline comments.Mar 10 2018, 2:29 PM
binaries/data/mods/public/simulation/templates/units/maur_champion_chariot.xml
16 ↗(On Diff #6107)

Because they don't have a rate defined. (The merchant ship also has capacities but no gather rates. Ship templates could be cleaned up at some point.)

binaries/data/mods/public/simulation/templates/units/pers_cavalry_archer_b.xml
14 ↗(On Diff #6107)

These were the only two that mentioned "trample".

elexis added inline comments.Mar 10 2018, 2:38 PM
binaries/data/mods/public/simulation/templates/units/maur_champion_chariot.xml
16 ↗(On Diff #6107)

(I have an abandoned revision proposal for ship parent templates, feel free to adapt or replace)

This revision was automatically updated to reflect the committed changes.