Fix rP21480
ClosedPublic
Actions

Authored by Stan on Mar 10 2018, 5:26 PM.

Details

Reviewers

vladislavbelov
Itms

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Summary

In rP21480 a typo was introduced where caster became caster hence breaking indexes. This patch fixes that.
It also fixes a typo where u8 was thought to be 16384

It also fixes a peculiar bug that didn't change the behaviour
Before this patch
x0 static_cast<u16>(g_HalfMaxCoord + g_HalfMaxCoord * svec.Y / svec.W));
-> x0 = 6493
Original and after this patch
x0 static_cast<u16>(g_HalfMaxCoord + static_cast<u16>(g_HalfMaxCoord * svec.Y / svec.W)));
-> x0 = 6494

Test Plan

Test everything is back to normal

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 5467
Build 9242: Vulcan Build	Jenkins

Event Timeline

Remove useless cast

remove extra space

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/215/display/redirect

Harbormaster completed remote builds in B5453: Diff 6118.Mar 10 2018, 5:30 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/216/display/redirect

Harbormaster completed remote builds in B5454: Diff 6119.Mar 10 2018, 5:33 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/217/display/redirect

Harbormaster completed remote builds in B5455: Diff 6120.Mar 10 2018, 5:36 PM

I do not get crash with patch.

I'm testing, two nitpicks first!

source/renderer/SilhouetteRenderer.cpp
104	On the other hand, this doesn't make much sense, `g_HalfMaxCoord = g_MaxCoord / 2;` would be better.
174	Since we access containers with this, `size_t` was better.