Differential D1373

Fix maps after kush temple rename
ClosedPublic
Actions

Authored by temple on Mar 10 2018, 5:37 PM.

Details

Reviewers

elexis

Commits

rP21486: Fix maps after kush temple rename

Summary

From rP21477, kush_temple_apedemak -> kush_temple.

Test Plan

grep to verify it's complete

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

temple created this revision.Mar 10 2018, 5:37 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/218/display/redirect

Harbormaster failed remote builds in B5456: Diff 6121!Mar 10 2018, 5:39 PM

(This is one of the use cases where we could permit a commit without review IMO, as there is hardly a way for temple to commit a wrong patch. Guess it can't be written as a universal law however)

This revision is now accepted and ready to land.Mar 10 2018, 5:49 PM

grepping yields:
./binaries/data/mods/public/simulation/ai/petra/headquarters.js: if (this.canBuild(gameState, "structures/{civ}_temple_apedemak"))
./binaries/data/mods/public/simulation/ai/petra/headquarters.js: templateName = "structures/{civ}_temple_apedemak";

In D1373#56564, @bb wrote:

grepping yields:
./binaries/data/mods/public/simulation/ai/petra/headquarters.js: if (this.canBuild(gameState, "structures/{civ}_temple_apedemak"))
./binaries/data/mods/public/simulation/ai/petra/headquarters.js: templateName = "structures/{civ}_temple_apedemak";

Yes, these two lines should be removed. But currently, they don't break anything as canBuild(apedemak) will return false if it does not find the template.

Thanks bb.

(I didn't say anything)

Harbormaster failed remote builds in B5457: Diff 6122!Mar 10 2018, 5:57 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/219/display/redirect

Closed by commit rP21486: Fix maps after kush temple rename (authored by temple). · Explain WhyMar 10 2018, 6:25 PM

This revision was automatically updated to reflect the committed changes.

Owners added subscribers: Restricted Owners Package, Restricted Owners Package.Mar 10 2018, 6:25 PM