removing and updating some outdated tips
Details
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 6795 Build 11176: Vulcan Build Jenkins Build 11175: arc lint + arc unit
Event Timeline
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/226/display/redirect
binaries/data/mods/public/gui/text/tips/whales.txt | ||
---|---|---|
9 | (blame gedit for hiding the last line confusing me to add it everywhere) |
binaries/data/mods/public/gui/text/tips/army_camp.txt | ||
---|---|---|
2 | This line seems to give an impression that it is possible to build it in allied territory. |
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/227/display/redirect
binaries/data/mods/public/gui/text/tips/army_camp.txt | ||
---|---|---|
2 | All buildings decay towards the territory owner, so this line is almost useless as is. It should warn the player that he should remember to garrison it to prevent decay at most. |
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/422/display/redirect
binaries/data/mods/public/gui/text/tips/army_camp.txt | ||
---|---|---|
2 | "Buildable in neutral [...]" | |
binaries/data/mods/public/gui/text/tips/pikemen.txt | ||
6 | Generally speaking, we seem to use the Serial comma (aka the "Oxford comma") in texts. So could we have one after "Ptolemies" please. | |
binaries/data/mods/public/gui/text/tips/scout_towers.txt | ||
4 | Keep resources the same way around (for consistency both here and elsewhere in the game's gui). Wood then Stone. | |
binaries/data/mods/public/gui/text/tips/war_elephants.txt | ||
8 | As mentioned in the relevant ticket, the Kushites should be added to this list. |
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/781/
Classes seem to be capitalized arbitrarily.
binaries/data/mods/public/gui/text/tips/army_camp.txt | ||
---|---|---|
2 | Can it not also be constructed in your own territory? | |
9 | Why are you removing these end-of-file lines? | |
binaries/data/mods/public/gui/text/tips/blacksmith.txt | ||
4 | If something is not implemented yet it might be better to remove mentioning it. | |
binaries/data/mods/public/gui/text/tips/civic_centres.txt | ||
7–8 | No Oxford comma? | |
binaries/data/mods/public/gui/text/tips/pericles.txt | ||
2 | Please use BC instead of BCE. | |
binaries/data/mods/public/gui/text/tips/pikemen.txt | ||
6 | Please alphabetize. | |
binaries/data/mods/public/gui/text/tips/quinquereme.txt | ||
1–2 | Carthaginians and Romans instead of Carthage and Rome. | |
6 | See earlier NIY comment. | |
binaries/data/mods/public/gui/text/tips/storehouses.txt | ||
2 | Resource types are capitalized elsewhere. | |
binaries/data/mods/public/gui/text/tips/war_elephants.txt | ||
8 | This tooltip has been corrected in rP21962 already. |
binaries/data/mods/public/gui/text/tips/blacksmith.txt | ||
---|---|---|
4 | I think there was a revision proposal where someone proposed to implement it, then it was abandoned, because weird feature. You should be able to find it with a search. Nuke it. |
binaries/data/mods/public/gui/text/tips/blacksmith.txt | ||
---|---|---|
4 | (Can be deleted or ignored upon commit) |
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/956/
binaries/data/mods/public/gui/text/tips/army_camp.txt | ||
---|---|---|
9 | That explains it, thanks. | |
binaries/data/mods/public/gui/text/tips/celtic_war_barge.txt | ||
4 | Available to Britons, Gauls, and Iberians. | |
6 | Remove " across the waters". | |
10 | Triremes can't ram either, therefore remove this line. | |
binaries/data/mods/public/gui/text/tips/civic_centres.txt | ||
8 | "citizen soldiers" → "citizen-soldiers" | |
binaries/data/mods/public/gui/text/tips/embassies.txt | ||
2 | Carthage, Carthaginian faction, or Carthaginians. | |
binaries/data/mods/public/gui/text/tips/fortress.txt | ||
4 | Remove "strong units like". | |
binaries/data/mods/public/gui/text/tips/gathering.txt | ||
2 | "citizen soldiers" → "citizen-soldiers" | |
4 | "are faster gathering ..." → "gather ... faster" | |
binaries/data/mods/public/gui/text/tips/persian_architecture.txt | ||
2 | Technology → technology | |
7–8 | & → and | |
7–8 | Actually I think it's better to delete this line. | |
binaries/data/mods/public/gui/text/tips/quinquereme.txt | ||
0–1 | Replace with "QUINQUEREME" | |
binaries/data/mods/public/gui/text/tips/scout_towers.txt | ||
6 | Actually the attack does not increase, only the number of arrows does, up to a certain maximum. | |
binaries/data/mods/public/gui/text/tips/spartan_hoplites.txt | ||
4 | Remove "faction". | |
binaries/data/mods/public/gui/text/tips/stoa.txt | ||
2 | Replace "Greek factions" with those that actually can build this structure. | |
binaries/data/mods/public/gui/text/tips/syntagma.txt | ||
0 | Perhaps it's better to completely delete this tooltip. | |
binaries/data/mods/public/gui/text/tips/temples.txt | ||
6 | Replace with simply - Research healing technologies. | |
binaries/data/mods/public/gui/text/tips/territory_decay.txt | ||
1–2 | There shouldn't be a white line here. | |
binaries/data/mods/public/gui/text/tips/triremes.txt | ||
4 | "Hellenic factions" is ill-defined; replace it by listing all factions that have triremes. (Kushites?) | |
binaries/data/mods/public/gui/text/tips/viriato.txt | ||
4 | 7 → seven | |
binaries/data/mods/public/gui/text/tips/war_elephants.txt | ||
4 | Check if the last part is true. |
Also, I'd appreciate it if the hyphens could be replaced with bullets ("•" instead of "-").
binaries/data/mods/public/gui/text/tips/army_camp.txt | ||
---|---|---|
9 | Actually there is only one empty line, not two, I just checked, so there is no need to remove them. | |
binaries/data/mods/public/gui/text/tips/celtic_war_barge.txt | ||
2 | Remove the " | |
binaries/data/mods/public/gui/text/tips/embassies.txt | ||
2 | Remove the " | |
5–6 | Remove the " | |
binaries/data/mods/public/gui/text/tips/temples.txt | ||
8 | Remove the " | |
binaries/data/mods/public/gui/text/tips/viriato.txt | ||
4 | Remove the ' | |
4 | B.C → BC | |
8 | Remove the " | |
8 | Has the GT aura that allows ... |
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/969/
binaries/data/mods/public/gui/text/tips/temples.txt | ||
---|---|---|
10 | may be better wounded ? |
binaries/data/mods/public/gui/text/tips/temples.txt | ||
---|---|---|
10 | Yes, wounded is better. |