Differential D1378

Address concerns of rP20321
ClosedPublic
Actions

Authored by Dunedan on Mar 11 2018, 6:49 PM.

Details

Reviewers

Imarok

Commits

rP21508: Address concerns of rP20321

Test Plan

Test that the concerns are addressed as expected.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Dunedan created this revision.Mar 11 2018, 6:49 PM

The reviewer from the original patch should make the decision (I would gladly give Imarok less work but I'm a bit overwhelmed myself at the moment).

Imarok accepted this revision.Mar 11 2018, 7:31 PM

This revision is now accepted and ready to land.Mar 11 2018, 7:31 PM

Closed by commit rP21508: Address concerns of rP20321 (authored by Imarok). · Explain WhyMar 11 2018, 7:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

ps/

trunk/

source/

lobby/

glooxwrapper/

glooxwrapper.h

2 lines

glooxwrapper.cpp

2 lines

Diff 6143

View Options

ps/trunk/source/lobby/glooxwrapper/glooxwrapper.h