Paths

Table of Contentst

Differential D1379

Add ceasefirecounter to default.cfg, rename watershadows to shadowsonwater
ClosedPublic
Actions

Authored by temple on Mar 11 2018, 9:41 PM.

Details

Reviewers

Commits

rP21585: Add ceasefirecounter to default.cfg, rename watershadows to shadowsonwater

Summary

An exhaustive search of options.json finds only these entries missing from default.cfg:

	"config": "playername.singleplayer"
	"config": "playername.multiplayer"
	"config": "gui.session.ceasefirecounter"
	"config": "watershadows",

gui.session.ceasefirecounter was missing from rP16624.
watershadows should've been changed to shadowsonwater in rP15473.

Test Plan

Agree.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

temple created this revision.Mar 11 2018, 9:41 PM

temple updated this revision to Diff 6150.Mar 11 2018, 11:52 PM

temple retitled this revision from Add ceasefirecounter to default.cfg to Add ceasefirecounter to default.cfg, rename watershadows to shadowsonwater.

temple edited the summary of this revision. (Show Details)

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/232/display/redirect

Harbormaster completed remote builds in B5497: Diff 6148.Mar 12 2018, 3:25 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/234/display/redirect

Harbormaster completed remote builds in B5505: Diff 6150.Mar 12 2018, 10:03 AM

indeed now all relevant options are in default correctly, the other way around is another story for another revision...

This revision is now accepted and ready to land.Mar 17 2018, 11:09 PM

elexis awarded a token.Mar 17 2018, 11:14 PM

Closed by commit rP21585: Add ceasefirecounter to default.cfg, rename watershadows to shadowsonwater (authored by temple). · Explain WhyMar 18 2018, 8:02 PM

This revision was automatically updated to reflect the committed changes.

Owners added a subscriber: Restricted Owners Package.Mar 18 2018, 8:02 PM

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

config/

default.cfg

1 line

mods/

public/

gui/

options/

options.json

2 lines

Diff 6212

View Options

ps/trunk/binaries/data/config/default.cfg