Open portrait dialog with left-click, not rightclick
AbandonedPublic
Actions

Authored by elexis on Mar 13 2018, 3:32 AM.

Details

Reviewers

Summary

I always found it weird that the selection details portrait has a rightclick action but no left-click action.
It was added in D297.

In my understanding of mouse button interaction, if there is only one action, the first mouse button is assigned to it.
If there are two, the second mouse button gets the second one.

Test Plan

Agree or not.

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

/ps/trunk

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 5525
Build 9323: Vulcan Build	Jenkins
Build 9322: arc lint + arc unit

Event Timeline

elexis created this revision.Mar 13 2018, 3:32 AM

Harbormaster completed remote builds in B5525: Diff 6158.Mar 13 2018, 3:32 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/239/display/redirect

Harbormaster completed remote builds in B5525: Diff 6158.Mar 13 2018, 3:37 AM

I guess I hard s0600204s opinion already (consistency with the selection panel buttons). fpre and temple also find it ok. Still the first time I see this, maybe I'm not the only one. Can be abandoned however.

@Imarok @bb @ffffffff @temple got an opinion?

Probably a bit more intuitive, so sure.

Just allow right and left click.

elexis abandoned this revision.Jun 7 2018, 12:40 AM

Why did you abandon?
I think nothing speaks against allowing right and left click.

Revision Contents
Changeset List

Path

Size

binaries/

data/

mods/

public/

gui/

session/

selection_details.js

4 lines

Diff 6158

View Options

binaries/data/mods/public/gui/session/selection_details.js

Open portrait dialog with left-click, not rightclickAbandonedPublicActions