Page MenuHomeWildfire Games

Fix player owned resources in Egypt.
ClosedPublic

Authored by lyv on Mar 15 2018, 7:38 AM.

Details

Summary

Some resources such as trees and fish etc were placed as player owned instead of gaia owned.

Test Plan

Check whether anything that should be owned by player is gaia owned. (most likely would not happen)

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lyv created this revision.Mar 15 2018, 7:38 AM
Owners added a subscriber: Restricted Owners Package.Mar 15 2018, 7:38 AM
Vulcan added a subscriber: Vulcan.Mar 15 2018, 7:40 AM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/247/display/redirect

elexis accepted this revision.Mar 16 2018, 5:05 PM

Checked the patch with cat binaries/data/mods/public/maps/skirmishes/Egypt\ \(4\).xml | grep 'Player>1' -i -B1 (yes that can be shortified)

I failed to find any benches on the map, so I don't know if those should be played owned (they can be captured by territory, so if they are in the intial lterritory, they should be owned by the player)

			<Template>other/bench</Template>
			<Player>1</Player>

Thanks for the diff!

This revision is now accepted and ready to land.Mar 16 2018, 5:05 PM
This revision was automatically updated to reflect the committed changes.