Page MenuHomeWildfire Games

Fix Skybox

Authored by Stan on Mar 18 2018, 8:11 PM.


Group Reviewers
Restricted Owners Package(Owns No Changed Paths)


This is the lazy way.

Correct way would imply getting the camera position, to make the skybox virtually unreachable.
Also fixing the hardcoding in that file, and allowing pngs.

Test Plan

Agree it's better.

Diff Detail

rP 0 A.D. Public Repository
Lint Skipped
Unit Tests Skipped
Build Status
Buildable 5615
Build 9448: Vulcan BuildJenkins

Event Timeline

Stan created this revision.Mar 18 2018, 8:11 PM
Stan edited the summary of this revision. (Show Details)
Vulcan added a subscriber: Vulcan.Mar 18 2018, 9:44 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build:

Currently vertical squares at this pictures aren't really squares:

I think, because the expression should be true: D * 2 == H - FH, as it's the box.

Stan added a comment.Mar 18 2018, 11:20 PM

So D = 1500
H = 2000
FH = 1000

right ?

Stan updated this revision to Diff 6216.Mar 18 2018, 11:21 PM

Tweak the values slightly to be a box

Successful build - Chance fights ever on the side of the prudent.

Link to build:

wraitii accepted this revision.May 14 2018, 12:04 PM
This revision is now accepted and ready to land.May 14 2018, 12:04 PM
elexis added a subscriber: elexis.May 14 2018, 12:08 PM

Numbers that work more often than not are an improvement.
But I suspect this will only work for some maps.
When working with the a23 trailer, I noticed that using any kind of number here is insufficient because every map can be different.
Jebel Barkal loads this atlas map thing and the default height is way above 0.
So this should use some computation if it wants to fix that.

This fixes the squeezing at the very least.

Stan added a comment.EditedMay 14 2018, 12:12 PM

The goal was to fix the fact that the mountain goes through the skybox. And the stretching.
That's done.

I think, the sky shouldn't be a box, it should be divided for clouds and sky. And clouds should present in the map coordinate system. But the sky is just a sphere with 1.0f radius, that's rendered without depth.

Stan abandoned this revision.Dec 26 2018, 4:50 PM

Superseeded by D1683