Differential D1411
Add commandline flag to set source and execution charsets to utf-8 Authored by Itms on Mar 23 2018, 5:36 PM.
Details
Add /utf-8 as a commandline compiler flag. Only supported in VS2015, so can't make it work for VS2013. Sets execution and source charsets to utf-8, preventing issues with Non-English Locale settings (e.g. Japanese or Chinese) on Windows. See #5094 for further info. Update workspaces and see if /utf-8 pops up in Project properties -> C/C++ -> Command Line. If non-English locale, test if building works and does not throw any errors like "illegal escape sequence" or "newline in constant"
Diff Detail
Event TimelineComment Actions Sorry it took so long. <failure file="F:\Jenkins\workspace\0adtest\source\scriptinterface\tests\test_ScriptConversions.h" line="69" type="failedAssertEquals" >Error: Expected (std::string(source) == std::string(expected)), found ("\"\\u0442\\u0435\\u0441\\u0442\"" != "\"\\xD1\\u201A\\xD0\\xB5\\xD1\\x81\\xD1\\u201A\"")
Error: Expected (std::string(source) == std::string(expected)), found ("\"\\u0442\\x00\\u0441\\u0442\"" != "\"\\xD1\\x00\\xD0\\xB5\\xD1\\x81\\xD1\\u201A\"")</failure>
</testcase>Comment Actions Thanks again for the patch Inari. I am commandeering it to fix the tests as well. I will commit this just after D2524. @Angen As you can see the current tests are testing that Windows does something specific and different from all other platforms; the change by Inari removes the discrepancy. Comment Actions Tests fixed. I removed the comment in the lua file but I can add it back, or change it, if you feel like this needs a comment. Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/915/display/redirect Comment Actions Build failure - The Moirai have given mortals hearts that can endure. Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1431/display/redirect Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/macos-differential/9/display/redirect Comment Actions Build failure - The Moirai have given mortals hearts that can endure. Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1432/display/redirect Comment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... source/scriptinterface/tests/test_ScriptConversions.h | 31| class·TestScriptConversions·:·public·CxxTest::TestSuite | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classTestScriptConversions:' is invalid C code. Use --std or --language to configure the language. Executing section JS... Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1433/display/redirect Comment Actions I can confirm it is building on windows with non english local settings, but I cannot test build with Chinese or Japanese locals. Maybe ask gameboy if he can try to build this one. |