FindWalkAndFightTargets is done in the PATROL timer, so it makes sense to add it to this function that's used in the COMBAT.ATTACKING timer.
(Might be worth considering merging PATROL and WALKINGANDFIGHTING since they're almost the same state.)
Details
Details
- Reviewers
mimo - Commits
- rP21633: Add Patrol check to IsWalkingAndFighting
Agree.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Yes, they process the patrol order for a turn and move towards the patrol point rather than staying where they are and attacking a new target.
Comment Actions
Yes, agree with the patch.
Maybe changing the name of the function IsWalkingAndFighting to indicate that it is not restricted to WalkAndFight would help? but i've not found good proposition.
Comment Actions
Possibly merging the patrol state sounds possibly reasonable too. Dunno if the patch is complete.
(Patrol was committed on a feature freeze day on sep 1st where lots of features were committed that were left over)
binaries/data/mods/public/simulation/components/UnitAI.js | ||
---|---|---|
3321 ↗ | (On Diff #6282) | Update comment |