When running pyrogenesis -mod=mod, I get
WARNING: Window icon not found.
This is fixed by moving the icon to the mod mod.
Details
Details
Reproduce the warning and check it is fixed. Take a look at the window icon as well.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
I experienced it too. I'm wondering though is that Icon is pyrogenesis or 0 A.D. Like if one day we make a full engine split will it make sense to have it still in mod mod ?
Comment Actions
If we do the engine split (which I might want to do next release) and someone comes up with a logo for pyrogenesis, we can have an icon in the mod mod and a 0 A.D. icon in the public mod.
Comment Actions
In this case we might want to duplicate the icon instead of moving it. I believe SVN has a copy option :)
Comment Actions
I cant test it with regards to rendering since my window manager doesn't display these icons.
But I could confirm that the file is read with your patch, as I get the warning if the filename were wrong or the thing not mounted.
I can also confirm that the described problem exists and that it's solved with this patch.
I'm ok with both moving and copying as proposed by Stan.