Add More anims to the actor viewer
ClosedPublic
Actions

Authored by Stan on Apr 4 2018, 1:14 PM.

Details

Reviewers

vladislavbelov
LordGood

Summary

Currently one cannot see the carry idle animations as well as the phalanx animations in atlas, this patches adresses that.

Test Plan

Open atlas, open actor viewer, see there are new anims.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 5750
Build 9651: Vulcan Build	Jenkins

Event Timeline

Stan created this revision.Apr 4 2018, 1:14 PM

I'd vote for deleting that whitespace instead of changing the alignment of all lines each time we add a longer string.
The patch would be much easier to review if the reader just had to compare 5 lines instead of 65.

Remove all whitespaces

Add the XML header, all files should have it.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/340/display/redirect

Harbormaster failed remote builds in B5750: Diff 6314!Apr 4 2018, 2:50 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/339/display/redirect

Harbormaster failed remote builds in B5749: Diff 6313!Apr 4 2018, 2:51 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/338/display/redirect

Harbormaster failed remote builds in B5748: Diff 6312!Apr 4 2018, 2:51 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/341/display/redirect

Harbormaster failed remote builds in B5750: Diff 6314!Apr 4 2018, 6:13 PM

Why no newline on the EOF?

It says "end of property" in the line that sets the eol-native property. I never understood that, does that really mean the file ending?

No that's the property. I do not really know where it's written. Maybe in the .svn folder ? Anyways tortoise never adds an eol but I can't add it manually.

Then it's ok. The patch looks good for me.

vladislavbelov accepted this revision.Apr 6 2018, 2:05 PM

This revision is now accepted and ready to land.Apr 6 2018, 2:05 PM

Stan closed this revision.Apr 7 2018, 8:46 PM