If the wallpiece is shorter than the obstruction size, then the wall foundation might not be constructible, see D1439.
Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Trac Tickets
- #5118
Pick one of the two places where the warning is added. The checkrefs script seems a better place. But it would have to be renamed in theory, as it then not only checks for references.
Perhaps a new perl script would be better.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 5784 Build 9699: Vulcan Build Jenkins Build 9698: arc lint + arc unit
Event Timeline
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Default... Executing section Source... Executing section JS... | | [NORMAL] ESLintBear (operator-linebreak): | | '||' should be placed at the end of the line. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/globalscripts/Templates.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/globalscripts/Templates.js | 87| 87| // If the elements are still strings, split them by space or by '+' | 88| 88| if (typeof sublist == "string") | 89| 89| sublist = sublist.split(/[+\s]+/); | 90| |- if (sublist.every(c => (c[0] == "!" && classes.indexOf(c.substr(1)) == -1) | 91| |- || (c[0] != "!" && classes.indexOf(c) != -1))) | | 90|+ if (sublist.every(c => (c[0] == "!" && classes.indexOf(c.substr(1)) == -1) || | | 91|+ (c[0] != "!" && classes.indexOf(c) != -1))) | 92| 92| return true; | 93| 93| } | 94| 94| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/globalscripts/Templates.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/globalscripts/Templates.js | 226| 226| { | 227| 227| let aura = auraTemplates[auraID]; | 228| 228| ret.auras[auraID] = { | 229| |- "name": aura.auraName, | | 229|+ "name": aura.auraName, | 230| 230| "description": aura.auraDescription || null, | 231| 231| "radius": aura.radius || null | 232| 232| }; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/globalscripts/Templates.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/globalscripts/Templates.js | 227| 227| let aura = auraTemplates[auraID]; | 228| 228| ret.auras[auraID] = { | 229| 229| "name": aura.auraName, | 230| |- "description": aura.auraDescription || null, | | 230|+ "description": aura.auraDescription || null, | 231| 231| "radius": aura.radius || null | 232| 232| }; | 233| 233| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/globalscripts/Templates.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/globalscripts/Templates.js | 228| 228| ret.auras[auraID] = { | 229| 229| "name": aura.auraName, | 230| 230| "description": aura.auraDescription || null, | 231| |- "radius": aura.radius || null | | 231|+ "radius": aura.radius || null | 232| 232| }; | 233| 233| } | 234| 234| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/globalscripts/Templates.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/globalscripts/Templates.js | 229| 229| "name": aura.auraName, | 230| 230| "description": aura.auraDescription || null, | 231| 231| "radius": aura.radius || null | 232| |- }; | | 232|+ }; | 233| 233| } | 234| 234| } | 235| 235| binaries/data/mods/public/globalscripts/Templates.js | 91| » » ····················||·(c[0]·!=·"!"·&&·classes.indexOf(c)·!=·-1))) | | [NORMAL] JSHintBear: | | Misleading line break before '||'; readers may interpret this as an expression boundary.
Link to build: https://jenkins.wildfiregames.com/job/differential/355/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Default... Executing section Source... Executing section JS... | | [NORMAL] ESLintBear (operator-linebreak): | | '||' should be placed at the end of the line. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/globalscripts/Templates.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/globalscripts/Templates.js | 87| 87| // If the elements are still strings, split them by space or by '+' | 88| 88| if (typeof sublist == "string") | 89| 89| sublist = sublist.split(/[+\s]+/); | 90| |- if (sublist.every(c => (c[0] == "!" && classes.indexOf(c.substr(1)) == -1) | 91| |- || (c[0] != "!" && classes.indexOf(c) != -1))) | | 90|+ if (sublist.every(c => (c[0] == "!" && classes.indexOf(c.substr(1)) == -1) || | | 91|+ (c[0] != "!" && classes.indexOf(c) != -1))) | 92| 92| return true; | 93| 93| } | 94| 94| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/globalscripts/Templates.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/globalscripts/Templates.js | 226| 226| { | 227| 227| let aura = auraTemplates[auraID]; | 228| 228| ret.auras[auraID] = { | 229| |- "name": aura.auraName, | | 229|+ "name": aura.auraName, | 230| 230| "description": aura.auraDescription || null, | 231| 231| "radius": aura.radius || null | 232| 232| }; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/globalscripts/Templates.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/globalscripts/Templates.js | 227| 227| let aura = auraTemplates[auraID]; | 228| 228| ret.auras[auraID] = { | 229| 229| "name": aura.auraName, | 230| |- "description": aura.auraDescription || null, | | 230|+ "description": aura.auraDescription || null, | 231| 231| "radius": aura.radius || null | 232| 232| }; | 233| 233| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/globalscripts/Templates.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/globalscripts/Templates.js | 228| 228| ret.auras[auraID] = { | 229| 229| "name": aura.auraName, | 230| 230| "description": aura.auraDescription || null, | 231| |- "radius": aura.radius || null | | 231|+ "radius": aura.radius || null | 232| 232| }; | 233| 233| } | 234| 234| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/globalscripts/Templates.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/globalscripts/Templates.js | 229| 229| "name": aura.auraName, | 230| 230| "description": aura.auraDescription || null, | 231| 231| "radius": aura.radius || null | 232| |- }; | | 232|+ }; | 233| 233| } | 234| 234| } | 235| 235| binaries/data/mods/public/globalscripts/Templates.js | 91| » » ····················||·(c[0]·!=·"!"·&&·classes.indexOf(c)·!=·-1))) | | [NORMAL] JSHintBear: | | Misleading line break before '||'; readers may interpret this as an expression boundary.
Link to build: https://jenkins.wildfiregames.com/job/differential/356/display/redirect
I have no idea what these perl scripts are doing and there are no comments, so I'd rather we had a new script, but we don't have a lot of conventions on that.
It'd be nice to be able to run JS scripts, I think we need to try and run these scripts as a static-analysis pre-step too.
If you're going to put it in the JS, make it an error imo.