Page MenuHomeWildfire Games
Differential D1456

Fix compilation of ModInstaller without pch
ClosedPublic
Actions

Authored by Imarok on Apr 17 2018, 11:19 PM.

Details

Reviewers
elexis
Itms
Commits
rP21739: Fix compilation of ModInstaller without pch
Summary

see title

Test Plan

pass --without-pch

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Imarok created this revision.Apr 17 2018, 11:19 PM
Imarok mentioned this in rP21726: Add a mod installer, fixes #4027..Apr 17 2018, 11:20 PM
elexis accepted this revision.Apr 17 2018, 11:24 PM

Yes, that's also what the other files in ps/ include and it fixes the build.

This revision is now accepted and ready to land.Apr 17 2018, 11:24 PM
Vulcan added a subscriber: Vulcan.Apr 18 2018, 12:00 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/401/display/redirect

Harbormaster completed remote builds in B5895: Diff 6417.Apr 18 2018, 12:01 AM
Closed by commit rP21739: Fix compilation of ModInstaller without pch (authored by Imarok). · Explain WhyApr 18 2018, 12:02 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
ps/
trunk/
source/
ps/
1 line

Diff 6418

View Options

ps/trunk/source/ps/ModInstaller.h

Loading...
Wildfire Games · Phabricator