Page MenuHomeWildfire Games

Unit for summary charts time axis
AcceptedPublic

Authored by ffffffff on Apr 21 2018, 8:12 PM.

Details

Reviewers
vladislavbelov
bb
Summary

proposal

Test Plan

charts

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

ffffffff created this revision.Apr 21 2018, 8:12 PM
bb accepted this revision.Apr 23 2018, 5:34 PM
bb added a subscriber: bb.

for after release

This revision is now accepted and ready to land.Apr 23 2018, 5:34 PM
bb added a comment.Dec 26 2018, 5:52 PM

Was about to commit it, but the time displayed is minutes : seconds, so shouldn't the unit be something like minutes:ss?

elexis added a subscriber: elexis.Mon, Jun 24, 4:25 AM

hh:mm would seem appropriate on the graphs, and the axis labels usually appears on the graph axis.

I see m:ss on charts of very short replays, so it seems problematic to only add min.

Perhaps it would be better to have the unit right after the number, i.e. 46s, 1m 28s, or 1h 20m.