Page MenuHomeWildfire Games

Conquest structures fails on nomad
Needs ReviewPublic

Authored by bb on Apr 24 2018, 4:49 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Trac Tickets
#3749
Summary

An approach to #3749, simply add conquestcritical query to units and structures conquest.

This doen't help in the case there are no player units on the map, but then either the hell broke loose, or it is wanted (some triggermap or so), so leaving that as is.

The conquestcritical is now in all 3 conquests, so might aswell be merged into common.

Not too happy with the solution myself however (not that I see a better one though)

Test Plan

Make sure no other edgy cases occur

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6530
Build 10799: Vulcan BuildJenkins
Build 10798: arc lint + arc unit

Event Timeline

bb created this revision.Apr 24 2018, 4:49 PM
Owners added a subscriber: Restricted Owners Package.Apr 24 2018, 4:49 PM
Vulcan added a subscriber: Vulcan.Apr 24 2018, 5:07 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/435/display/redirect

temple added a subscriber: temple.Apr 26 2018, 2:58 AM

Now you can lose with conquest structures even if you have structures left, or lose with conquest units even if you have units left. Non-conquest-critical ones (e.g. market + traders), but still.
Not sure about an alternative solution, other than to advise people not to choose conquest structures when playing nomad.

elexis added a subscriber: elexis.Apr 26 2018, 3:54 AM

The expectance is that the player is defeated if the nomad units are lost if there is no structure yet, or if there was a non-foundation structure already but all structures were lost.
That can be decided with code, right?

wraitii added a reviewer: Restricted Owners Package.May 14 2018, 11:55 AM
bb added a comment.Jun 1 2018, 10:12 PM
In D1469#60219, @temple wrote:

Now you can lose with conquest structures even if you have structures left, or lose with conquest units even if you have units left. Non-conquest-critical ones (e.g. market + traders), but still.
Not sure about an alternative solution, other than to advise people not to choose conquest structures when playing nomad.

Not too hard to solve that, use classfliter: "ConquestCritical Structures" (Units) instead

bb updated this revision to Diff 7072.Dec 26 2018, 9:05 PM

fix the edgy case when only nonConquestCritical structures/units remain

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/834/