Differential D1469

Conquest structures fails on nomad
ClosedPublic
Actions

Authored by bb on Apr 24 2018, 4:49 PM.

Details

Reviewers

Silier

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP23874: Defeat players on conquestStructures nomad who don't build anything.

Trac Tickets

#3749

Summary

An approach to #3749, simply add conquestcritical query to units and structures conquest.

This doen't help in the case there are no player units on the map, but then either the hell broke loose, or it is wanted (some triggermap or so), so leaving that as is.

Not too happy with the solution myself however (not that I see a better one though)

Test Plan

Make sure no other edgy cases occur

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bb created this revision.Apr 24 2018, 4:49 PM

Owners added a subscriber: Restricted Owners Package.Apr 24 2018, 4:49 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/435/display/redirect

Harbormaster completed remote builds in B5965: Diff 6469.Apr 24 2018, 5:07 PM

Now you can lose with conquest structures even if you have structures left, or lose with conquest units even if you have units left. Non-conquest-critical ones (e.g. market + traders), but still.
Not sure about an alternative solution, other than to advise people not to choose conquest structures when playing nomad.

The expectance is that the player is defeated if the nomad units are lost if there is no structure yet, or if there was a non-foundation structure already but all structures were lost.
That can be decided with code, right?

wraitii added a reviewer: Restricted Owners Package.May 14 2018, 11:55 AM

In D1469#60219, @temple wrote:

Now you can lose with conquest structures even if you have structures left, or lose with conquest units even if you have units left. Non-conquest-critical ones (e.g. market + traders), but still.
Not sure about an alternative solution, other than to advise people not to choose conquest structures when playing nomad.

Not too hard to solve that, use classfliter: "ConquestCritical Structures" (Units) instead

fix the edgy case when only nonConquestCritical structures/units remain

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/834/

Harbormaster completed remote builds in B6530: Diff 7072.Dec 26 2018, 9:10 PM

bb edited the summary of this revision. (Show Details)Jun 23 2020, 12:10 AM

Silier added a reviewer: Silier.Jul 22 2020, 11:42 AM

I have tested all combinations of conquest victories with nomad and without nomad settings.
All worked correctly.

This revision is now accepted and ready to land.Jul 22 2020, 9:30 PM

Closed by commit rP23874: Defeat players on conquestStructures nomad who don't build anything. (authored by bb). · Explain WhyJul 23 2020, 3:40 PM

This revision was automatically updated to reflect the committed changes.

bb added a commit: rP23874: Defeat players on conquestStructures nomad who don't build anything..