Also consider switching order for lobby in mainmenu multiplayer submenu from last to first position.
Maybe u want to bring replays also in main menu below tools&options [for a direct hit][as it is quite common to use].
Details
- Reviewers
elexis vladislavbelov
review
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Event Timeline
Create Game part:
- Renaming "Host Game" to "Create Game" sounds okay to me, but the tooltip could and should still use "Host".
Notice this renaming should also (even more importantly) be done in lobby.xml as that's the place where the crowd gathers.
We don't have tooltips for the lobby buttons, but that property can be easily added.
- If the intention is to make it more obvious to newcomers how the multiplayer function works,
then we might conisder moving the tooltip in the mainmenu from the top right corner (where it conflicts with the gametime and fps counter)
to the bottom left side where it is closer to the selected menu options (so that the tooltip is actually noticed).
- The host tooltip is outdated, as it says that 20595 needs to be forwarded (while hosts can specify arbitrary posts). Also grammatically suboptimal terminology "open".
- This host tooltip should explain the difference between a multiplayer lobby and the 'create game' in the main menu.
- Also don't change anything in the l10n directory, as these files are generated automatically
Replay Menu:
Nice, I feel confirmed as I have proposed that a couple of times myself!
Many newcomers and even longtime players are not aware that a replay menu exists at all!
Nor is a replay menu a tool or an option.
Same is true for the map editor, it could be moved right below the replay button.
Then the "Tools & Options" part could become "Options" instead of having this weird umbrella term.
This has been discussed in http://irclogs.wildfiregames.com/2016-11-10-QuakeNet-%230ad-dev.log from 19:12 onwards.
I'm not exactly sure what the concern has been, I don't believe those options should be hidden in a "Tools" or "Options" menu.
(Also thought about moving the "Replay" button to both Singleplayer and Multiplayer submenu (as we can also filter for only SP replays and MP replays), but not really convinced of that)
What I really want is someone else with a strong opinion, as I don't want to impose my strong opinion.
I think moving "Replays" and "Scenario Editor" to the main menu is a very good idea.
(Maybe we should additionally rename "Scenario Editor" to "Map Editor")
As @elexis said, all string changes should be in *.xml/*.js, not in translation file, they'll generated automatically.
I like to move Replays to the main menu.
But I'm not sure about Host > Create, Host means, that a player has rights to game, game will be hosted at his computer, but Create is more common word, also Create a server is used in most video games, not Create a game, Create a game it's more like single-player.
I'm going to have to agree with vladislav, "Create" rather hides the fact that they are the host (even if we have NAT traversal and stuff, it probably won't work on some networks and they might wonder why).
they already wonder and not knowing what hosting means. but sometimes they have upnp enablement on their router and therfor can normaly create a game, while being the creator they are also the hoster (technicly). this they will likely being feeling fast when setting the game settings (also for others.). it seems just to be a to technical term. its just like not joining a server (or room) its creating them. and its created on their on pc of course. therfor can set all options of game and others can join their game. maybe a little tooltip can show they gonna "host a game"