This makes Xcode project target 10.8 by default, instead of the latest OSX (which may actually be more recent than what is running on the host).
(adding you Vladislav, I believe you have OS X)
Differential D1482
Target build version explicitly for Xcode wraitii on May 5 2018, 7:00 PM. Authored by
Details
This makes Xcode project target 10.8 by default, instead of the latest OSX (which may actually be more recent than what is running on the host). (adding you Vladislav, I believe you have OS X) Somebody on OSX should review this.
Diff Detail
Event TimelineComment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/differential/461/display/redirect Comment Actions You need to update premake4.lua too, no? Also we shouldn't forget to update our wiki too. Comment Actions Getting this right doesn't seem like it would hurt the A23 re release was it to be included, right @Itms ? Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/differential/812/ Comment Actions I agree, but I think you didn't test this? The option must be accessed with _OPTIONS (see the other use of it in the file for an example) and I suggest running the whole premake script with and without the parameter passed. Comment Actions I assumed we should use premake variable because options might be undefined. -- On OS X, sometimes we need to specify the minimum API version to use if _OPTIONS["macosx-version-min"] then buildoptions { "-mmacosx-version-min=" .. _OPTIONS["macosx-version-min"] } -- clang and llvm-gcc look at mmacosx-version-min to determine link target -- and CRT version, and use it to set the macosx_version_min linker flag linkoptions { "-mmacosx-version-min=" .. _OPTIONS["macosx-version-min"] } end Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/differential/813/ Comment Actions The patch is currently useless, because xcodebuildsettings was added in premake5 alpha12 (we have alpha10): see https://github.com/premake/premake-core/wiki/xcodebuildsettings. So this should be bumped to A24. At that point, D1685 will be in, so this patch should be rebased and pass --macosx-version-min="${MIN_OSX_VERSION}" to premake when generating the xcode workspaces. Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/differential/1081/display/redirect Comment Actions This looks good to me now. Can somebody test on XCode (I don't have it on my VMs) and commit if it works as expected? Comment Actions I suggest setting 10.12 as the new min version (but that can be overturned), and Xcode could use setting the min OSX version too. Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/differential/1210/display/redirect Comment Actions Hi Lancelot ? Let's not change the minimum version, we worked hard enough during the rerelease to make sure we could keep 10.9 as the minimum. Apart from that, if it works for you I can accept. Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/differential/1227/display/redirect |