Page MenuHomeWildfire Games

curl OSX build script fix
ClosedPublic

Authored by Itms on May 12 2018, 2:46 PM.

Details

Summary

Disable explicitly the use of nghttp2.

Test Plan

Tested by @trompetin17.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.May 12 2018, 2:46 PM
Vulcan added a subscriber: Vulcan.May 12 2018, 2:58 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/475/display/redirect

Stan added a subscriber: Stan.May 12 2018, 3:48 PM

One should not forget to update the webpage and the wiki if/once this gets committed.

elexis marked an inline comment as done.
elexis added inline comments.
build/workspaces/build-osx-bundle.sh
28 ↗(On Diff #6527)

See more research in D1654, me assuming that this is some kind of workaround

Itms commandeered this revision.Sun, Dec 2, 3:08 PM
Itms added a reviewer: elexis.

Instead of abandoning this revision which was superseded by D1610, D1609 and D1685 (in order of committing), I take the liberty to commandeer it to include yet another manual disabling of a library we do not use.

Itms updated this revision to Diff 7018.Sun, Dec 2, 3:13 PM
Itms retitled this revision from curl OSX build script fixes to curl OSX build script fix.
Itms edited the summary of this revision. (Show Details)
Itms edited the test plan for this revision. (Show Details)
Itms edited reviewers, added: trompetin17; removed: wraitii, elexis.
Itms added subscribers: trompetin17, elexis, wraitii.

Yet another lib that might be detected by configure even though we don't have it and we don't need it. Disabling it explicitly is needed to link pyrogenesis.

Vulcan added a comment.Sun, Dec 2, 3:14 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/810/

This revision was not accepted when it landed; it landed in state Needs Review.Sun, Dec 2, 9:42 PM
Closed by commit rP21939: Minor change to the libcurl macOS compilation. (authored by Itms, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.