Page MenuHomeWildfire Games

Combat Variant
Needs RevisionPublic

Authored by Alexandermb on May 17 2018, 7:42 AM.

Details

Reviewers
temple
wraitii
Stan
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Owners Package(Owns No Changed Paths)
Summary

Hello everyone i've made this mod for made a little change on the visual perspective between combat and city for myself with little changes but maybe someone could enjoy it too or have an use of it on their own projects, this is just an addition of what the UnitAi already has in the "COMBAT">"APPROACHING" line replacing the default animation variant with the "combat" one defined in the end of some infantry actor files, this patch has some of the actors edited to have their respective ready variant already ingame made by Enrique

Forum topic:
name

Test Plan

The main objective of this is to make a difference between natural and combat aggresive visual behavior for the infantry, so they no longer walk relaxed into a battle.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

Alexandermb created this revision.May 17 2018, 7:42 AM
Stan added reviewers: Restricted Owners Package, Restricted Owners Package.May 17 2018, 8:04 AM
Stan added reviewers: temple, wraitii.
Stan requested changes to this revision.Jan 23 2019, 11:32 AM
Stan added a subscriber: Stan.

This will likely need to be rebased, would be nice if someone who has experience with the simulation could review that.

This revision now requires changes to proceed.Jan 23 2019, 11:32 AM
lyv added a subscriber: lyv.EditedJan 23 2019, 1:36 PM

Due to the lack of context I can’t be sure, but is the variant reset upon leaving the state?

Related albeit not the same? #2503

Stan added a comment.Sep 5 2019, 9:08 PM

Yeah though instead of being relative to a range check it's relative to the state.

In D1496#94055, @Stan wrote:

Yeah though instead of being relative to a range check it's relative to the state.

We'd probably want it to be related to the range right? For it is strange for a unit to be in the combat mood when tasked from the one end of a map to the other?

Silier added a subscriber: Silier.Sep 9 2019, 3:11 PM

yes possibly but first it would be better just have this one as it is a lot faster than computing squares and this just changes unitai code in minimal scale

Stan added a comment.Sep 9 2019, 4:06 PM

Patch probably needs rebase now.

But actually this seems to only set the units to use combat variant when in formation.

Freagarach added a comment.EditedSep 9 2019, 4:20 PM
In D1496#94455, @Stan wrote:

But actually this seems to only set the units to use combat variant when in formation.

Yeah, the rest of the code is already there :) At least in SVN now.