Page MenuHomeWildfire Games

Proposal for a replace button for observer in game when player want leave and observer can switch in
Needs ReviewPublic

Authored by ffffffff on Feb 19 2017, 11:53 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

only ip and port in game is needed.

functionality is same as rejoin by ip and replacing name

elexis proposed variables passing through pages, from lobby, else,... (working)

further more check if player which to switch is offline of course (to be done)

ingame replacement working.

Test Plan

review test a

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

ffffffff created this revision.Feb 19 2017, 11:53 AM

looks this

notice top right replace arrow.

ffffffff edited the summary of this revision. (Show Details)Feb 19 2017, 11:55 AM
ffffffff edited the summary of this revision. (Show Details)Feb 19 2017, 12:37 PM
elexis resigned from this revision.Feb 19 2017, 8:53 PM

I agree that a feature to replace players is useful, as players sometimes don't have time to continue matches while observers are happy to rejoin.
In fact it is widely used already (by joining the game via IP under the same nickname).

BUT a correct implementation has the additional requirements:

  • The playername is updated too, so that every client is aware that there is a new player in the game
  • Replays should contain this information as well, so we have to add a player-replacement notification simulation command
  • Either the host or the replaced player must approve of the replacement, otherwise everyone can just replace arbitrarily if someone goes offline

Unfortunately the patch is entirely nonfunctional and the implementation is nothing for people unfamiliar with the engine code.
You might have to abandon this proposal :-/

In D150#5315, @elexis wrote:

I agree that a feature to replace players is useful, as players sometimes don't have time to continue matches while observers are happy to rejoin.
In fact it is widely used already (by joining the game via IP under the same nickname).
BUT a correct implementation has the additional requirements:

  • The playername is updated too, so that every client is aware that there is a new player in the game
  • Replays should contain this information as well, so we have to add a player-replacement notification simulation command
  • Either the host or the replaced player must approve of the replacement, otherwise everyone can just replace arbitrarily if someone goes offline

Unfortunately the patch is entirely nonfunctional and the implementation is nothing for people unfamiliar with the engine code.
You might have to abandon this proposal :-/

this is a shortcut for the already used method of rejoining by ip.

dont outrage this to any engine stufff...

stand rejoin:

ffffffff updated this revision to Diff 670.EditedMar 2 2017, 1:18 AM

status ready

button top bar next to observer selection names. u can select observing player and hitting replace button u rejoin as him (Works if hes offline).

elexis added a comment.Mar 2 2017, 1:53 AM

I'm positively surprised by your proposal. The BUT part is mandatory though, we can't have people arbitrarily replacing each other without host confirmation or player notification, it will be an invitation for trolls and impersonation :-7

In D150#6943, @elexis wrote:

I'm positively surprised by your proposal. The BUT part is mandatory though, we can't have people arbitrarily replacing each other without host confirmation or player notification, it will be an invitation for trolls and impersonation :-7

circcumstances are not ready. acknowledged. maybe some engine js code changes in game needed (architecturely) ..

ffffffff updated this revision to Diff 675.Mar 2 2017, 2:57 PM
ffffffff edited the summary of this revision. (Show Details)
ffffffff edited the summary of this revision. (Show Details)
ffffffff edited the summary of this revision. (Show Details)
echotangoecho resigned from this revision.Mar 10 2017, 10:56 PM

(I don't have time to review this but I will keep watching this)

Imarok added a comment.Oct 1 2017, 6:38 PM

Please create a ticket for that feature, where we can discuss, how this should work.
If we come to an agreement, I'll look into doing the engine code part.
Maybe this functionality should be placed in the network window(#3787)?