Page MenuHomeWildfire Games

Remove some unused functions
Needs RevisionPublic

Authored by wraitii on May 19 2018, 3:24 PM.

Details

Reviewers
Stan
vladislavbelov
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

Ported from leper's inevitable 0003.

This removes unused functions.

Test Plan

Compile.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
leper_03_unused
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6089
Build 10138: Vulcan BuildJenkins
Build 10137: arc lint + arc unit

Event Timeline

wraitii created this revision.May 19 2018, 3:24 PM
Vulcan added a subscriber: Vulcan.May 19 2018, 3:29 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/516/display/redirect

2018 is already going :)

(About SoundGroup there is in soundmanager/SoundManager.(cpp/h) and soundmanager/scripting/SoundGroup.(cpp/h) an entity_id_t source parsed all over the place which is unused everywhere iirc. The end leaf is ItemForEntity but one had to climb the tree.
By the way I have strange things when typing @leper, is it a phabricator formatting issue?)

Stan added a subscriber: Stan.May 19 2018, 4:30 PM

The soundgroup changes are likely already a part of D1270

Stan requested changes to this revision.Jan 2 2019, 11:38 PM

Needs to be rebased as of rP22009

This revision now requires changes to proceed.Jan 2 2019, 11:38 PM