From leper's inevitable.zip
Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths)
Compile.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- D1508_map_triggers
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 6614 Build 10910: Vulcan Build Jenkins Build 10909: arc lint + arc unit
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/521/display/redirect
| source/graphics/MapReader.cpp | ||
|---|---|---|
| 921 | Declaration of this function is not removed. | |
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/differential/858/
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/862/
Comment Actions
Err, as leper said on that
For this diff I'd like a bump of the map version, apart from that it looks good (and more complete than some diff I had locally). I did somewhat finish up the patch about adding gaia to the player array in maps, so it might be nice to get these two in consecutively, so the map version bump is only done once and handles both of these.
And indeed this is less complete than D642, so I'll abandon this.