pilino1234 reported a bad capitalization on Transifex (Rally-Points → Rally-points).
I took the chance to remove the unnecessary hyphen between the words.
Details
Details
- Reviewers
bb Stan Nescio - Commits
- rP22128: rally-point → rally point
Affects only user-visible strings.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues:
Executing section Default...
Executing section Source...
Executing section JS...
| | [NORMAL] ESLintBear (curly):
| | Unnecessary { after 'if' condition.
|----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/tutorials/starting_economy_walkthrough.js
| |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/tutorials/starting_economy_walkthrough.js
| 430| 430| "OnPlayerCommand": function(msg)
| 431| 431| {
| 432| 432| if (msg.cmd.type == "gather" && msg.cmd.target)
| 433| |- {
| | 433|+
| 434| 434| if (TriggerHelper.GetResourceType(msg.cmd.target).generic == "stone")
| 435| 435| this.stone = true;
| 436| 436| else if (TriggerHelper.GetResourceType(msg.cmd.target).generic == "metal")
| 437| 437| this.metal = true;
| 438| |- }
| | 438|+
| 439| 439| if (this.IsDone())
| 440| 440| this.NextGoal();
| 441| 441| },Link to build: https://jenkins.wildfiregames.com/job/differential/577/display/redirect
Comment Actions
I believe “Focus on Rally Point” is correct, as the whole sentence is in title case, it being the name of an action.
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues:
Executing section Source...
Executing section JS...
| | [NORMAL] ESLintBear (curly):
| | Unnecessary { after 'if' condition.
|----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/tutorials/starting_economy_walkthrough.js
| |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/tutorials/starting_economy_walkthrough.js
| 430| 430| "OnPlayerCommand": function(msg)
| 431| 431| {
| 432| 432| if (msg.cmd.type == "gather" && msg.cmd.target)
| 433| |- {
| | 433|+
| 434| 434| if (TriggerHelper.GetResourceType(msg.cmd.target).generic == "stone")
| 435| 435| this.stone = true;
| 436| 436| else if (TriggerHelper.GetResourceType(msg.cmd.target).generic == "metal")
| 437| 437| this.metal = true;
| 438| |- }
| | 438|+
| 439| 439| if (this.IsDone())
| 440| 440| this.NextGoal();
| 441| 441| },
Executing section cli...Link to build: https://jenkins.wildfiregames.com/job/differential/1115/display/redirect