Reported by kingu on Transifex.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 6176 Build 10263: Vulcan Build Jenkins
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues:
Executing section Default...
Executing section Source...
Executing section JS...
| | [NORMAL] ESLintBear (curly):
| | Unnecessary { after 'if' condition.
|----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/tutorials/starting_economy_walkthrough.js
| |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/tutorials/starting_economy_walkthrough.js
| 430| 430| "OnPlayerCommand": function(msg)
| 431| 431| {
| 432| 432| if (msg.cmd.type == "gather" && msg.cmd.target)
| 433| |- {
| | 433|+
| 434| 434| if (TriggerHelper.GetResourceType(msg.cmd.target).generic == "stone")
| 435| 435| this.stone = true;
| 436| 436| else if (TriggerHelper.GetResourceType(msg.cmd.target).generic == "metal")
| 437| 437| this.metal = true;
| 438| |- }
| | 438|+
| 439| 439| if (this.IsDone())
| 440| 440| this.NextGoal();
| 441| 441| },Link to build: https://jenkins.wildfiregames.com/job/differential/593/display/redirect
Comment Actions
certainly (didn't check if more of these cases occur, presumably yes, but that requires reading through all strings => meh)