Page MenuHomeWildfire Games

Replace periods with semicolons in network error reasons
AbandonedPublic

Authored by Gallaecio on May 28 2018, 11:07 PM.

Details

Reviewers
elexis
Summary

kingu reported in Transifex that one of the strings describing a reason for a network error was missing a period, but it turned out that it was missing on purpose because the strings was meant to be inserted into another string: "Reason: %(reason)s.".

But if the "reason" is to be a single sentence, it makes more sense to use semicolons instead of periods in reason strings. Otherwise, we should take the period out of the "Reason: %(reason)s." string and add it to every "reason" string.

Test Plan

It only affects user-visible strings.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 6179
Build 10266: Vulcan BuildJenkins

Event Timeline

Gallaecio created this revision.May 28 2018, 11:07 PM
Vulcan added a subscriber: Vulcan.May 28 2018, 11:09 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/596/display/redirect

Otherwise, we should take the period out of the "Reason: %(reason)s." string and add it to every "reason" string.

Yep, D1366 (was too close to stringfreeze unfortunately)

Gallaecio abandoned this revision.May 29 2018, 1:24 PM

Nice, I’ll close this one then.