Page MenuHomeWildfire Games

Also write oos_dump.dat when writing oos_dump.txt
ClosedPublic

Authored by elexis on May 29 2018, 3:24 AM.

Details

Summary

Sometimes there is only a hash mismatch while the textual simstate representations are equal.
We gave a replay to about 10 players and none could reproduce the issue in #5162.
If the binary dump would have been recorded we would have had more information to see what went wrong.

Test Plan

Start hosting, change a template or random map script constant, rejoin, see that the file is written and contains binary data with the familiar sim component property names.
Some wiki pages may need to be updated.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.May 29 2018, 3:24 AM
Vulcan added a subscriber: Vulcan.May 29 2018, 3:30 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/598/display/redirect

temple accepted this revision.May 29 2018, 4:28 AM
temple added a subscriber: temple.

Tested, works. Would've saved us some time analyzing the recent oos issues, so hopefully will save us time in the future.

This revision is now accepted and ready to land.May 29 2018, 4:28 AM
This revision was automatically updated to reflect the committed changes.