Page MenuHomeWildfire Games

Rephrase the description of the wonder victory condition
ClosedPublic

Authored by Gallaecio on Jun 2 2018, 11:50 AM.

Details

Summary

Reported by pilino1234 on Transifex.

Test Plan

Only affect a user-visible string.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Gallaecio created this revision.Jun 2 2018, 11:50 AM
Vulcan added a subscriber: Vulcan.Jun 2 2018, 11:52 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/614/display/redirect

bb added inline comments.Jun 8 2018, 9:36 PM
binaries/data/mods/public/simulation/data/settings/victory_conditions/wonder.json
6 ↗(On Diff #6701)

hmm, grammer i guess, in the proposed string, owners is plural right? while there is only 1 owner of a wonder

Gallaecio updated this revision to Diff 6743.Jun 9 2018, 3:52 PM

Switched ‘owners’ to ‘owner’, as reported by @bb.

Gallaecio marked an inline comment as done.Jun 9 2018, 3:53 PM
Vulcan added a comment.Jun 9 2018, 3:54 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/640/display/redirect

bb accepted this revision.Jun 18 2018, 4:07 PM
This revision is now accepted and ready to land.Jun 18 2018, 4:07 PM
elexis added a subscriber: elexis.Jun 18 2018, 4:46 PM

Perhaps "allied victory mode"? (At least the phrasing in our code, gamemode used to be synonymous with victory condition.)

Gallaecio updated this revision to Diff 6822.Jul 26 2018, 7:24 PM

game mode → mode, as suggested by @elexis.

The current wonder victory behavior to reset the timer if someone of that team is defeated or changed the alliance.
That behavior is currently marked as contested in rP21441 and might be changed.
If the previous alliance and defeat conditions (excluding the originally reported bug) were restored, the sentence would be deleted.
(Otherwise the string should be improved to also contain the information that the timer is reset upon defeat.)

This revision was automatically updated to reflect the committed changes.