Currently there is no confirmation of the end of the packaging. This is an issue especially on windows, where the cmd is not able to grasp the debug_printf; This patch sends a final message so you don't have to rely on hacks to figure out if the process exited.
Details
Details
- Reviewers
vladislavbelov elexis - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP22042: Add a confirmation message when packaging ends.
Package a mod, and see it prints a final message. For instance using (Linux users beware of \)
pyrogenesis.exe -mod=no-blood-and-gore-mod -archivebuild="..\data\mods\no-blood-and-gore-mod" -archivebuild-compress -archivebuild-output="no-blood-and-gore-mod.2.pyromod"
it will print
Finished packaging "no-blood-and-gore-mod.2.pyromod".
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/differential/663/display/redirect
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/664/display/redirect
Comment Actions
Line itself is as correct as the other ones in this function, because the other log outputs in this function use debug_printf and string8 too.
Line in the right place, because the function contains debug_printfs already for progress output and the caller doesn't.
blablabla
Didn't test.
2019.