Page MenuHomeWildfire Games
Differential D1594

FreeBSD does not have MAP_NORESERVE
Needs ReviewPublic
Actions

Authored by madpilot on Jul 5 2018, 5:52 PM.

Details

Reviewers
Itms
Trac Tickets
#5255
Summary

As from subject, I added conditionals to remove that flag when compiling in FreeBSD.

As far as I know FreeBSD is always working in overcommit mode, so the flag is implicitly always active.

Test Plan

Tested in FreeBSD.

Similar patch without conditionals, only removing the MAP_NORESERVE flag committed to the FreeBSD ports tree.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6278
Build 10419: Vulcan BuildJenkins
Build 10418: arc lint + arc unit

Event Timeline

madpilot created this revision.Jul 5 2018, 5:52 PM
Vulcan added a subscriber: Vulcan.Jul 5 2018, 5:58 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/674/display/redirect

Revision Contents
Changeset List

Diff 6800

View Options

source/lib/allocators/page_aligned.cpp

Loading...
View Options

source/lib/sysdep/os/unix/uvm.cpp

Loading...
Wildfire Games · Phabricator