When game loading fails (Map error for example) the user is sent back to the main menu with an error box. This is done without stopping the xmpp client. Therefore, xmpp messsage are still recieved.
Details
Details
To reproduce: Fail a game loading (can mess up an RMS). Go to the prelobby page. Warnings would be displayed showing lobby messages.
Do the above with and without the patch.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/683/display/redirect
Comment Actions
Seems correct
| binaries/data/mods/public/gui/common/functions_global_object.js | ||
|---|---|---|
| 86 ↗ | (On Diff #6811) | There's a switchpage in InitPs just before CancelLoad already, sounds like this one is redundant |
| binaries/data/mods/public/gui/common/functions_global_object.js | ||
|---|---|---|
| 86 ↗ | (On Diff #6811) | I have not investigated further but looks like the switchpage actually being used is this one. Thats just a conclusion derived after removing that line. |
| binaries/data/mods/public/gui/common/functions_global_object.js | ||
|---|---|---|
| 86 ↗ | (On Diff #6811) | Both ones are executed, I guess the former one is only relevant to not assume this one having a switchpage and in case there wasnt a GUI being setup before (autostartmode?) |