Currently it displays 2015 in the installer, and sometimes things fail depending on the dev environment.
Details
Details
- Reviewers
Stan elexis - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP21931: Small changes to the macOS build scripts.
/
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 6442 Build 10671: Vulcan Build Jenkins
Event Timeline
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/differential/715/display/redirect
| build/workspaces/build-osx-bundle.sh | ||
|---|---|---|
| 214 | $(date +%Y) | |
Comment Actions
@Stan If you don't mind, I'm commandeering this one to have all the small changes to macOS scripts in one diff! :slight_smile:
Comment Actions
Small changes to the macOS scripts.
- date update based on previous patch
- the --enable-64bit flag is needed for nspr when developing on recent versions (we are already building 64bit only)
- the --without-libpsl precision is needed to avoid issues when libpsl is installed and detected
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/775/
Comment Actions
That:?
The --enable-64bit parameter is required on an x86_64 system to prevent configure failing with a claim that this is a system without pthread support. The [ $(uname -m) = x86_64 ] test ensures it has no effect on a 32 bit system.
http://www.linuxfromscratch.org/blfs/view/svn/general/nspr.html
(Anyway, if it's our policy to build for 64bit only, then the technical background is irrelevant.)
https://ec.haxx.se/building-deps.html
When you build curl with support for libpsl, the cookie parser will know about the Public Suffix List and thus handle such cookies appropriately.
So Public Suffix List is used to enforce privacy rules on cookies afaics.
Since neither mod.io nor UserReporter use cookies (proven by the absence of the word COOKIE in the files, https://ec.haxx.se/libcurl-http-cookies.html), it seems safe to build without libPSL (and it would yield a smaller footprint in comparison to including it needlessly).
So no clue if the diff is necessary or complete for some technical issues, but the diff is not adding anything wrong for any platform.
| build/workspaces/build-osx-bundle.sh | ||
|---|---|---|
| 214 | (ah, you're already in the contributors list) | |
Comment Actions
Tested by Tobbi: He had to compile with this NSPR flag too on macOS 10.13.6, but could also compile without the PSL one (presumably as he didnt install it).