Page MenuHomeWildfire Games

Adding new rmgen placers and painters and a special filter for buildings.
AbandonedPublic

Authored by nani on Aug 19 2018, 12:12 AM.

Details

Reviewers
FeXoR
elexis
Summary

PolygonPlacer lets you get an area from a non convex polygon.
DunePainter generates the height of procedural dunes given an area.
PerlinPainter generates the height of perlin noise given an area.
Perlin_noise.js defines the perlin fucntion for PerlinPainter .
disableGarrisonHolder.xml is a special filter to make a buildings ungarrisonable.

Test Plan

The map Dune uses DunePainter.
The map Fert and Fert Mountain uses PerlinPainter.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

nani created this revision.Aug 19 2018, 12:12 AM
nani updated this revision to Diff 6862.Aug 19 2018, 2:36 AM

Following style conventions

smiley added a subscriber: smiley.Aug 19 2018, 3:01 AM

Also add yourself to programming.json if you havent in one of the other revision proposals.

binaries/data/mods/public/maps/random/rmgen/placer/noncentered/PolygonPlacer.js
22

Wat?

27

Why not inline this? Looks kinda out if place.

nani updated this revision to Diff 6863.Aug 19 2018, 3:19 AM

Improved code style

nani added inline comments.Aug 19 2018, 3:45 AM
binaries/data/mods/public/maps/random/rmgen/placer/noncentered/PolygonPlacer.js
27

a named function gives information for what it does

nani updated this revision to Diff 6869.Aug 19 2018, 11:20 PM
nani edited the summary of this revision. (Show Details)
nani edited the test plan for this revision. (Show Details)
nani set the repository for this revision to rP 0 A.D. Public Repository.

Improved PolygonPlacer efficiency and fixed artifacts.
Improved style and readability of code.

FeXoR added a comment.EditedAug 26 2018, 2:37 PM

This patch contains several things that are not really related to each other.

Do you want to have this functions in for your maps?
Because if so I'd suggest you focus to improve your maps and try to get one or more into the main repository.
Then the needed painters are likely to get in, too.

To work on your maps and show us your progress the forum is likely better suited and, if the maps are close to ready, you may add a new diff for that specific map.

To make it more clear: I won't except this patch in it's current state without a pressing reason why to commit it.

FeXoR requested changes to this revision.Sep 18 2018, 12:36 PM
This revision now requires changes to proceed.Sep 18 2018, 12:36 PM
nani abandoned this revision.Sep 20 2018, 7:41 AM

I will make separated diffs for each feature.