Page MenuHomeWildfire Games

PerlinPainter add to rmgen.
Needs ReviewPublic

Authored by nani on Sep 22 2018, 1:35 AM.

Details

Reviewers
FeXoR
Summary

PerlinPainter is the rmgen painter implementation of perlinPainter D1630: Add perlin noise generator.

Test Plan

Used in map Fert: https://code.wildfiregames.com/D1634

Test map:

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 10238
Build 17394: arc lint + arc unit

Event Timeline

nani created this revision.Sep 22 2018, 1:35 AM
nani created this object with visibility "nani".
nani edited the test plan for this revision. (Show Details)Sep 22 2018, 5:33 PM
nani changed the visibility from "nani" to "Public (No Login Required)".Sep 22 2018, 5:54 PM
FeXoR added a reviewer: FeXoR.Sat, Nov 30, 8:23 PM
FeXoR added a subscriber: FeXoR.

Missing newline at the end of the file.
Otherwise I'm to tired to review this right now. Let's call it a day ;)

FeXoR added a comment.Sat, Dec 7, 6:56 PM

And that newline at the end of file. Otherwise it's fine ;)

binaries/data/mods/public/maps/random/rmgen/painter/PerlinPainter.js
4

Specify that the is an array of Vector2D objects representing tiles.

FeXoR requested changes to this revision.Sat, Dec 7, 6:58 PM
This revision now requires changes to proceed.Sat, Dec 7, 6:58 PM
Stan added a subscriber: Stan.Sat, Dec 7, 7:01 PM
Stan added inline comments.
binaries/data/mods/public/maps/random/rmgen/painter/PerlinPainter.js
11

I think there are no caps https://jsdoc.app/tags-returns.html for js doc
also if it's an array, one can write Vector2D[] or object[]

nani updated this revision to Diff 10524.Sat, Dec 7, 10:43 PM
nani edited the summary of this revision. (Show Details)
Owners added a subscriber: Restricted Owners Package.Sat, Dec 7, 10:43 PM
nani edited the test plan for this revision. (Show Details)Sat, Dec 7, 10:46 PM
Krinkle added a subscriber: Krinkle.Sun, Dec 8, 3:17 AM
Krinkle added inline comments.
binaries/data/mods/public/maps/random/rmgen/painter/PerlinPainter.js
4

Must*

nani updated this revision to Diff 10525.Sun, Dec 8, 3:27 AM

Bust -> Must

nani marked 3 inline comments as done.Sun, Dec 8, 3:28 AM
nani added a parent revision: D2454: Add 2d value noise for rmgen..