Page MenuHomeWildfire Games

Fert random map.
Needs ReviewPublic

Authored by nani on Sep 22 2018, 1:45 AM.

Details

Reviewers
elexis
FeXoR
Summary
Test Plan

No test plan.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7123
Build 11626: arc lint + arc unit

Event Timeline

nani created this revision.Sep 22 2018, 1:45 AM
nani changed the edit policy from "All Users" to "nani".Sep 22 2018, 1:50 AM
nani changed the visibility from "Public (No Login Required)" to "nani".
nani changed the visibility from "nani" to "Public (No Login Required)".Sep 22 2018, 5:54 PM
nani updated this revision to Diff 7689.Apr 7 2019, 12:58 AM

Cleanup & made it a little more pretty.

Owners added a subscriber: Restricted Owners Package.Apr 7 2019, 12:58 AM
FeXoR added a subscriber: FeXoR.Nov 25 2019, 11:39 PM

The 'raster' lib is only used by this map so far so I'd suggest to import it in the map rather than in library.js.
I didn't see this map before and so far it looks good!
Eager to test it ;)

I'd suggest adding a reviewer so someone gets notified of your work waiting to enter ;)

Stan added a subscriber: Stan.Dec 10 2019, 7:50 AM

Is there no way to force victory conditions?
Would be nice to have this gamemode as a victory condition :)

nani added a comment.Dec 10 2019, 8:01 AM
In D1634#103111, @Stan wrote:

Is there no way to force victory conditions?
Would be nice to have this gamemode as a victory condition :)

@elexis seems to be working on it

nani changed the edit policy from "nani" to "All Users".Jan 14 2020, 3:21 PM

Is there no way to force victory conditions?

Why not allow the host to vary the map more by playing with other or additional victory conditions?
Currently when selecting a skirmish/random map that comes with VictoryConditions, that choice is overwritten.
So the user still has to actively decide against the preference of the map.
(When playing in conquest, the player gaining the middle still has a big strategical advantage, and its the primary passage connecting the players, so the victory condition doesnt change the gameplay that much in case Conquest is enabled)
(It is quite easy to change the VictoryCondition format of maps to differentiate between forcing and overwriting a setting, the change could be local to VictoryConditions.js, except for the fact that Atlas would also need to be changed and perhaps the Gamesetup.cpp Autostart code)

  • If one wants both the unconquerable spiral hill and this proposed hill in the same mapgen, one could use the Landscape option from rP23392/D2564
  • What is a fert?
binaries/data/mods/public/maps/random/fert.js
2

rmgen2 unused? perhaps even more?

binaries/data/mods/public/maps/random/fert_triggers.js
6

disabledTemplates go to the JSON file (see polar sea example following D2483/rP23374)
(One could check whether {civ} placeholder is supported there)

8

(Not survival)

12

The template can't have the DamageReceiver removed (or is it the CaptureTheRelic gaia bug preventing that)?

binaries/data/mods/public/maps/random/rmgen/raster/primitives.js
13

(I didnt check how performance critical it is, but perhaps the clone can be avoided by passing an iterator vector and assigning the x/y value using the vector set method)

23

(that clone can be avoided with an iterator)

63

(Not sure how often it is called, but it sounds like the array construction can be avoided. Irrelevant for 10 arrays, but relevant for thousands to hundreds of thousands)

nani added a comment.Jan 14 2020, 3:49 PM
  • What is a fert?

Nothing. Made up. I initially wanted to name it "King of the hill" but sounded too cheesy. An alternative would be to translate it to Latin or such. Google tells me "king of the hill" in Latin is "Rex Monte" which sounds OK.

Angen added a subscriber: Angen.Jan 14 2020, 3:53 PM
In D1634#107361, @nani wrote:
  • What is a fert?

Nothing. Made up. I initially wanted to name it "King of the hill" but sounded too cheesy. An alternative would be to translate it to Latin or such. Google tells me "king of the hill" in Latin is "Rex Monte" which sounds OK.

Latin: fert -> counts

Nescio added a subscriber: Nescio.Jan 14 2020, 4:14 PM

Google tells me "king of the hill" in Latin is "Rex Monte" which sounds OK.

Don't trust Google. Use the proper case (genitivus): rex montis (mons means mountain; same root). Better still would be rex collis (collis means hill).

Latin: fert -> counts

fert is the third singular present of the verb fero, ferre, which means to carry, convey, transport, take (and a lot of other, similar things; it has eleven columns (four pages) in P. G. W. Glare Oxford Latin Dictionary (Oxford 2012)).