Differential D1645
Civ:gaia template clear-up Authored by Stan on Oct 2 2018, 7:45 PM.
Details Instead of adding <Civ>gaia</Civ> in numerous templates (not always consistently), it makes far more sense to define it only in the first parent. With this patch the Civ:gaia is present only in the following templates:
And it's removed from all their descendents. Effectively nothing should be changed
Diff Detail
Event TimelineComment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/differential/738/display/redirect Comment Actions This proposal makes sense so I accept, however, there might be in campaigns or Hyrule Conquest mod or other similar mod a problem with a variety of combinations of unusual characters and their behavior. Comment Actions
By accepting a patch you imply that the patch implements the proposal, has no bugs, is complete and the best solution for the claimed problem. Comment Actions It works fine on my end without any errors or warnings, and I did a grep, but I'm the author, so reviewers shouldn't believe me, and test for themselves. As for the parent template templates, template_gaia.xml ( https://trac.wildfiregames.com/browser/ps/trunk/binaries/data/mods/public/simulation/templates/template_gaia.xml ) and special/spy.xml (not sure if this is really necessary, but I suppose it doesn't hurt) already have <Civ>gaia</Civ> and this patch adds it to template_structure.xml and template_unit.xml. The only issue I can think of is that it solves the "no civ" warnings if a mod adds structures or units but omits defining a civ.
Actually I highly doubt it would break any mods, but please check yourself. Comment Actions (It would be cool to have a script which dumps all templates after inheriting and stuff) Comment Actions So I made a little C# script that checked all those files and confirmed they had no parents with Civ gaia. Checking for completeness is not really useful as it would make the commit bigger than it already is plus there is D1523 that will take care of animals, which are missing in that patch. |