Create gui-userreport.pot translation resource
ClosedPublic
Actions

Authored by elexis on Oct 12 2018, 4:50 PM.

Details

Reviewers

Itms

Commits

rP21905: Create UserReporter translation resource for rP21898 / D1598.

Summary

Someone should fix the messages.json syntax error, run updateTemplates.py and commit the new UserReporter translation resource rP21898, which is this diff, at least according to rP19731.

Test Plan

I don't know if calling maintenanceTasks.py which also calls updateTemplates.py is the better path.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Oct 12 2018, 4:50 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/740/display/redirect

Harbormaster completed remote builds in B6386: Diff 6922.Oct 12 2018, 4:58 PM

Yes this is good! As soon as it's committed, I'll run the translation bot.

I don't know if calling maintenanceTasks.py which also calls updateTemplates.py is the better path.

No difference here: maintenanceTasks also uses poediff to remove useless modifications, but that uses svn diff which won't work as long as a first version is not committed. So this Diff is perfect, the bot will pick it up from here. ?

This revision is now accepted and ready to land.Oct 12 2018, 9:56 PM

Closed by commit rP21905: Create UserReporter translation resource for rP21898 / D1598. (authored by elexis). · Explain WhyOct 13 2018, 2:07 AM

This revision was automatically updated to reflect the committed changes.